[PATCH v2] Re: accounts.py: Merge AccountSynchronizationMixin with SyncableAccount class
Nicolas Sebrecht
nicolas.s-dev at laposte.net
Mon Jan 31 17:49:18 GMT 2011
On Mon, Jan 31, 2011 at 03:53:35PM +0100, Sebastian Spaeth wrote:
>
> AccountSynchronizationMixin was never used on its own and it is a very
> confusing class until you understand what it is used for. (It
> complemented the Account() class with a few methods to make Account()
> syncable.
>
> But we use the SyncableAccount class anyway, so merge the former Mixin'
> methods directly in there.
>
> This does away with a class that is not directly used, and was a case of
> over-object-orientation which confuses more than it helps.
>
> Touched up code documentation while going through the file.
Thanks; delayed until next stable, though.
--
Nicolas Sebrecht
More information about the OfflineIMAP-project
mailing list