[PATCH] Re: docs/MANUAL.rst: remove leftover reference to old interface name

Nicolas Sebrecht nicolas.s-dev at laposte.net
Mon Jul 11 16:41:51 UTC 2011


On Sun, Jul 10, 2011 at 11:29:42PM +0200, Luca Capello wrote:

> People, it was over the week-end, so please be patient.

No problem, I didn't realize.

> FYI, even if I read your email before leaving for the week-end, given
> that I am still ignorant WRT the project policy about patches I needed
> time to investigate them.  For example, I still do not understand why
> me, as the patch author, should add any Signed-off-by: at all.

You'll find detailed documentation here:

https://github.com/nicolas33/offlineimap/blob/ce901800fff70e4b463e4e2b954e2a5553dfa628/SubmittingPatches.rst

The short explanation:

  add a Signed-off-by: Your Name <you at example.com> line to the commit
  message (or just use the option -s when committing) to confirm that you
  agree to the Developer's Certificate of Origin

Developer's Certificate of Origin 1.1

    By making a contribution to this project, I certify that:

       1.  The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated in
the file; or

       2.  The contribution is based upon previous work that, to the
best of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the same
open source license (unless I am permitted to submit under a different
license), as indicated in the file; or

       3.  The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified it.

       4.  I understand and agree that this project and the contribution
are public and that a record of the contribution (including all personal
information I submit with it, including my sign-off) is maintained
indefinitely and may be redistributed consistent with this project or
the open source license(s) involved.

> Moreover, I do not know at all how to add that Signed-off-by: above to
> the patch: should I pipe the email Sebastian sent me to Git?

You can only add it by hand as answer to the patch. I'm fine with this
kind of agreement.

Since it's your work in the first place, I expect you to have it in your
local repository. So, you may 'git commit --amend -s' your patch and
(re)send it.

Thanks,

-- 
Nicolas Sebrecht



More information about the OfflineIMAP-project mailing list