3 patch series on folder/Maildir cleanup

Nicolas Sebrecht nicolas.s-dev at laposte.net
Mon Jun 13 15:32:23 BST 2011


On Mon, Jun 13, 2011 at 03:20:36PM +0200, Sebastian Spaeth wrote:
> On Sun, 12 Jun 2011 21:34:47 +0200, Nicolas Sebrecht wrote:
> > I first applied these topics and finally reverted them because it's
> > broken:
> 
> Uhh, you hit a code path that I never did and I had left an old variable
> name lying around that should have been changed. I will be resending v2
> of patch #3 now, the rest of the patches remains the same. This is the
> interpatch diff:
> 
> diff --git a/offlineimap/folder/Maildir.py b/offlineimap/folder/Maildir.py
> index 61ee5f4..b576507 100644
> --- a/offlineimap/folder/Maildir.py
> +++ b/offlineimap/folder/Maildir.py
> @@ -249,7 +249,7 @@ class MaildirFolder(BaseFolder):
>          file.close()
>  
>          if rtime != None:
> -            os.utime(os.path.join(tmpdir, tmpmessagename), (rtime, rtime))
> +            os.utime(os.path.join(tmpdir, messagename), (rtime, rtime))

Thank you. Applied.

> Thanks for catching this. One more reason to be looking forward to the
> testing suite.

Sure. :-)

-- 
Nicolas Sebrecht




More information about the OfflineIMAP-project mailing list