[PATCH 1/4] Don't use CStringIO to format a traceback

Sebastian Spaeth Sebastian at SSpaeth.de
Tue Jun 14 09:23:39 BST 2011


The traceback module has format_exc() for this purpose so let's use that.

Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>
---
 offlineimap/ui/UIBase.py |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/offlineimap/ui/UIBase.py b/offlineimap/ui/UIBase.py
index 4c60b2a..5524579 100644
--- a/offlineimap/ui/UIBase.py
+++ b/offlineimap/ui/UIBase.py
@@ -21,7 +21,6 @@ import time
 import sys
 import traceback
 import threading
-from StringIO import StringIO
 import offlineimap
 
 debugtypes = {'':'Other offlineimap related sync messages',
@@ -309,10 +308,8 @@ class UIBase:
         s.terminate(100)
 
     def getMainExceptionString(s):
-        sbuf = StringIO()
-        traceback.print_exc(file = sbuf)
-        return "Main program terminated with exception:\n" + \
-               sbuf.getvalue() + "\n" + \
+        return "Main program terminated with exception:\n%s\n" %\
+               traceback.format_exc() + \
                s.getThreadDebugLog(threading.currentThread())
 
     def mainException(s):
-- 
1.7.4.1





More information about the OfflineIMAP-project mailing list