[PATCH] Re: Fix recursively scanning Maildir folders
nicolas.s-dev at laposte.net
Thu Jun 16 17:39:10 BST 2011
On Thu, Jun 16, 2011 at 05:09:29PM +0200, Sebastian Spaeth wrote:
> Commit 1754bf4110da251f4aa1dc0803889899b02bfcff introduced a blunder:
> - for dirname in os.listdir(toppath) + ['.']:
> + for dirname in os.listdir(toppath) + [toppath]:
> - if self.getsep() == '/' and dirname != '.':
> + if self.getsep() == '/' and dirname:
> This change was plainly wrong and would never have worked, so this
> commit reverts above bit. While touching the function, some minor code
> documentation, cleanup and limiting line length to 80 chars.
> Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>
> Not sure why I never tripped over this obvious mistake, despite me
> running the code daily. This is on top of master and recommended for master.
> The only functional change is the reverting of the above 2 lines, the rest is minor cleanup and documentation. Sorry for the blunder.
Thank you for the patch. There are too much unrelated stuff to get it
merged in master, though. Merged in next.
More information about the OfflineIMAP-project