[PATCH 3/4] Re: accounts.py: Use ui.error when raising exceptions

Nicolas Sebrecht nicolas.s-dev at laposte.net
Thu Jun 16 17:54:03 BST 2011


On Tue, Jun 14, 2011 at 10:23:41AM +0200, Sebastian Spaeth wrote:
> 
> Rather than using ui.warn, use ui.error() which outputs Exceptions to
> the error log, saving them to a stack, so we get notified again at the
> end of the sync run.
> 
> Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>
> ---
>  offlineimap/accounts.py |   23 +++++++++++++----------
>  1 files changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/offlineimap/accounts.py b/offlineimap/accounts.py
> index a989441..f0a18b6 100644
> --- a/offlineimap/accounts.py
> +++ b/offlineimap/accounts.py
> @@ -22,6 +22,7 @@ from offlineimap.threadutil import InstanceLimitedThread
>  from subprocess import Popen, PIPE
>  from threading import Event
>  import os
> +import sys

While this is correct, why not use

  from sys import [...]

?

-- 
Nicolas Sebrecht




More information about the OfflineIMAP-project mailing list