Remove superfluous ConfigedIMAPServer class

Nicolas Sebrecht nicolas.s-dev at
Thu Jun 16 18:00:38 BST 2011

On Wed, Jun 15, 2011 at 01:34:40PM +0200, Sebastian Spaeth wrote:
> I planned to implement SSL fingerprint checking, but for this, I need
> access to the repository configuration from within our SSLIMAP4
> instance, which was not possible. On my way to achieve this, I
> simplified the code to do away with the superfluous wrapper class
> ConfigedIMAPServer.
> I tested that fetching passwords via configuration and UI still work and
> that syncing is ok. I don't have the possiblity to test SSL tunnels, but
> they should keep working just fine.
> Despite some added code comments, we are still saving 50 LOC without
> obfuscation and simplifying the code.
> Patch against "next" branch as reply to this one.
> Sebastian
> P.S. This was one area where I said in the beginning of this year that I
> found the many layers of wrapping and abstraction confusing. With this
> patch we would have removed 2 layers of abstractions making the code
> simpler.

Yes, I remember. :-)

> PPS. The imapserver.acquireconnection() is obscenely large and is ripe
> for some refactoring if anyone wants to take it on.

I fully agree!

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list