[PATCH] Remove unneeded workaround for Darwin

Sebastian Spaeth Sebastian at SSpaeth.de
Wed Mar 2 08:36:11 UTC 2011


>     SS> There is a clumsy workaround for Darwin that chunks reads into
>     SS> 8kb blocks to avoid huge memory allocations.
> 
> I am the author of the workaround - sorry for the clumsiness !

Hi there,

Just to clarify: I was not referring quality of the code in question. :)

I would consider *every* workaround around this bug as clumsy. It is
simply ugly that MacOSX, or Mac Python are buggy in that regard and we
have to special case them (on the other hand, could we chunk reads on
all platforms, e.g. in case we receive *huge* emails, which would
currently be read in one go, if I understand correctly.)

So don't take this as an offense :-).

> That's probably fine then. Initially I only patched the non-SSL version,
> and that was not enough, but possibly things have changed since.

OK, as my patch only removes the SSL version that should be fine
then. On the other hand, if -as you say- current python versions on Mac
are still suffering then we should probably keep this in and add a
comment to that regard.

> By the way, 'python' now defaults to version 2.6 in snow leopard, so I
> guess the problem will solve itself anyway eventually.

Right, but we still need to cater for pre-snow leopard versions now, I
guess. Although Macies tend to upgrade really quickly :-).

Thanks for the information, much appreciated. So either lets keep this
one still in or lets just remove the SSL chunked read. (which is all *I*
care about ;-P).

Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/offlineimap-project/attachments/20110302/05e4a692/attachment.pgp>


More information about the OfflineIMAP-project mailing list