[PATCH] Re: Create an abstract Repository class

Nicolas Sebrecht nicolas.s-dev at laposte.net
Wed Mar 2 17:48:21 GMT 2011

On Wed, Mar 02, 2011 at 12:09:27PM +0100, Sebastian Spaeth wrote:
> A Repository() returns the correctly instanciated dervivate of a
> BaseRepository, depending on the parameters passed to it. The returned
> instance is eg an ImapRepository(). This makes the code look nicer,
> and we have less functions lying around outside of classes (no more
> global LoadRepository() function).
> This will also enable us to conveniently hand back a
> LocalStatusRepository based on SQLITE rather than plain text, if the
> user configures this to be the experimental and optional backend
> (once it exists).

Code looks correct to me even if it should be updated against current

> diff --git a/offlineimap/repository/__init__.py b/offlineimap/repository/__init__.py
> index be5c29e..ea97b27 100644
> --- a/offlineimap/repository/__init__.py
> +++ b/offlineimap/repository/__init__.py
> @@ -1 +1,71 @@
> -__all__ = ['Gmail', 'IMAP', 'Base', 'Maildir', 'LocalStatus']
> +# Copyright (C) 2002-2007 John Goerzen 
> +# <jgoerzen at complete.org>


What about

  Copyright (C) 2011 Sebastian Spaeth <your at email> and contributors.


Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list