[PATCH] Re: Fixed bug: wrong number of arguments to debug() [IMAP.py].

Nicolas Sebrecht nicolas.s-dev at laposte.net
Sun Mar 27 20:33:01 BST 2011

On Sun, Mar 27, 2011 at 08:56:51PM +0200, Sebastian Spaeth wrote:
> On Sat, 26 Mar 2011 19:43:37 -0400, David Favro <offlineimap at meta-dynamic.com> wrote:
> > Signed-off-by: David Favro <offlineimap at meta-dynamic.com>
> > -            self.ui.debug("Message with invalid date %s. Server will use local time." \
> > +            self.ui.debug('imap', "Message with invalid date %s. Server will use local time." \
> My bad entirely. The patch is of course right. This should go into the
> next stable release.

Looks good to me, too.

> Reviewed-by: Sebastian Spaeth <Sebastian at SSpaeth.de>

AFAIR, David is touching a portion of _code you've changed before_ if
not _rewritten entirely_. So, I would be enlighted if you agree to
increase your review by signing-off patches in this case. Also, this
means you did a stronger review than with a usual "Reviewed-by". I'll be
even more inclined to merge such signed-off patch.

This is all about "who I trust" most. So, this should not apply for code
you still didn't involved in yet. ,-)

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list