[PATCH] Re: FAQ: add two entries concerning 'sslcacertfile'

[Daniel Shahaf]

Nicolas Sebrecht wrote on Mon, May 09, 2011 at 19:47:15 +0200:
> On Sun, May 08, 2011 at 10:55:55PM +0300, Daniel Shahaf wrote:
> > 
> > Add a FAQ entry about non-verifying SSL certificates by default,
> > and another about how to generate a certificates file to feed to
> > the 'sslcacertfile' repository configuration item.
> > 
> > Signed-off-by: Daniel Shahaf <d.s at daniel.shahaf.name>
> > ---
> >  docs/FAQ.rst |   28 ++++++++++++++++++++++++++++
> >  1 files changed, 28 insertions(+), 0 deletions(-)
> > 
> > diff --git docs/FAQ.rst docs/FAQ.rst
> > index fcc55b3..ae4fbe2 100644
> > --- docs/FAQ.rst
> > +++ docs/FAQ.rst
> 
> Odd, I can't understand how you produced this patch. It can't apply like
> this. It's missing the correct semantic to the paths
> 
>   diff --git a/docs/FAQ.rst b/docs/FAQ.rst
>   index fcc55b3..ae4fbe2 100644
>   --- a/docs/FAQ.rst
>   +++ b/docs/FAQ.rst
> 
> It made me a few minutes before figuring out what happened. I've fixed
> the issue this time but please make sure your patches apply before
> sending them.
> 
> AFAIR, git never changed this semantic. So, I guess you used a standard
> tool like diff to produce this patch. I highly recommend using 'git
> format-patch' to avoid problems like that.
> 

I produced the patch using git(1) with diff.noprefix=1 in .gitconfig .

I didn't realize that setting would break applying patches I send.

> Fixed and applied.
> Thank you much to take care about the documentation.
> 

Thanks for accepting the patch.

> -- 
> Nicolas Sebrecht