[PATCH 2/2] Re: Fix broke warn statement

[Nicolas Sebrecht]

On Sat, May 07, 2011 at 06:27:28PM +0200, Sebastian Spaeth wrote:
> 
> This was a broken format statement, fixed now.

You should say /how/ it was broken. It's not so obvious and I had read
the changeset two times to undestand.

I'm change above line to:

  Use two %s in the message for both strings.

> diff --git a/offlineimap/accounts.py b/offlineimap/accounts.py
> index 0eb49dc..e4499fa 100644
> --- a/offlineimap/accounts.py
> +++ b/offlineimap/accounts.py
> @@ -219,8 +219,8 @@ class SyncableAccount(Account):
>                          if e.severity >= OfflineImapError.ERROR.CRITICAL:
>                              raise
>                  except:
> -                    self.ui.warn("Error occured attempting to sync "\
> -                                 "account '%s':\n"% (self, traceback.format_exc()))
> +                    self.ui.warn("Error occured attempting to sync account "\
> +                                 "'%s':\n%s"% (self, traceback.format_exc()))
>                  else:
>                      # after success sync, reset the looping counter to 3
>                      if self.refreshperiod:
-- 
Nicolas Sebrecht