[PATCH] threadutil: add missing import os

Sebastian Spaeth Sebastian at SSpaeth.de
Tue May 10 02:06:55 BST 2011

On Mon,  9 May 2011 22:59:07 +0200, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> Nobody seemed to raise a missing import which make me think this code is either
> highly broken (we have dead code) or very safe. It would ask a closer review of
> this area.

Good catch. The os.* calls are only exited on tread exit when

    if thread.getExitCause() == 'EXCEPTION':
    elif thread.getExitMessage() == 'SYNC_WITH_TIMER_TERMINATE':

and I cannot remember that we set anywhere ExitCause or ExitMessage :-),
so that code is probably not exercised at all. Yes, it calls for a review.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/offlineimap-project/attachments/20110510/8f2db0fc/attachment-0001.sig>

More information about the OfflineIMAP-project mailing list