[PATCH v2] refactoring: simplify the semaphorewait logic

Sebastian Spaeth Sebastian at SSpaeth.de
Wed May 11 21:24:44 BST 2011

On Wed, 11 May 2011 22:10:56 +0200, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> The semaphorewait()/waitforthread() logic is usefull for IMAP starting
> connections. We actually use it in imapserver only.
> -        threadutil.semaphorewait(self.semaphore)
> +        self.semaphore.acquire()
> +        self.semaphore.release()

Reviewed-by: Sebastian Spaeth <Sebastian at SSpaeth.de>

The patch is ok, but in the longer term, I would love to rename the
variable self.semaphore to something more useful. It is a semaphore for
WHAT? That is a very useless name ...

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/offlineimap-project/attachments/20110511/16dcd4fd/attachment-0001.sig>

More information about the OfflineIMAP-project mailing list