[PATCH 0/6] Re: Readd idle again

[Nicolas Sebrecht]

On Thu, May 19, 2011 at 09:35:04PM +0200, Nicolas Sebrecht wrote:

> I'm missing the interdiff. I created it this time:

<...>

> @@ -422,11 +422,14 @@ class IdleThread(object):
>              if "IDLE" in imapobj.capabilities:
>                  imapobj.idle(callback=callback)
>              else:
> +                self.ui = getglobalui()
> +                ui.warn("IMAP IDLE not supported on connection to %s; falling back to no-op"
> +                        %(imapobj.identifier,))

Not that this warning is strictly wrong but what should the (l)user
should understand from this message?  I'm pointing to the "no-np" part
which sounds totally crazy. Users would think

- "on what does it no-op?"
- "will it stop to work something? everything?"
- "why doesn't it do like if I didn't asked for IDLE to work?"

>                  imapobj.noop()
>              self.event.wait()
>              if self.event.isSet():
> +                # Can't NOOP on a bad connection.
>                  if not self.imapaborted:
> -                    # Can't NOOP on a bad connection.

Ahhh... I understand the code, now. ,-)

> > Once again, I hope you can apply this :)

:)

-- 
Nicolas Sebrecht