New logging framework on 'next' (Blinkenlights users beware)

[Sebastian Spaeth]

On Fri, 28 Oct 2011 14:37:08 +0200, Vincent Beffara <vbeffara at ens-lyon.fr> wrote:
> 
> >> TLDR; All UI backends have been converted to use python's logging
> >> module. The only one that still suffers from some stability issues is
> >> blinkenlights.
> 
> Nice work !
 
> One thing though, now running it as "offlineimap -o", with the output
> set to Basic, it hangs right after saying
> 
>     *** Finished account 'allimap' in 0:05
> 
> and I have to kill it using CTRL-C. git bisect tells me that

Hi Vincent, thanks for the report, you are right. I removed some stuff
From the threadutils that I thought was unused, but in fact we checked
for the weird exit message:

setExitMessage('SYNC_WITH_TIMER_TERMINATE')

of the SyncRunner thread. I have to admit that this is one of the last
areas I had not dared to touch/understand so far. But a special exit
message is still needed or we will never exit our "infinite"
threadutil.exitnotifymonitorloop(). I have fixed this in the below
commit in the next branch. We still use a special exit message, and
return from the exitnotifymonitorloop when the SynRunner thread exits.

Let me know if this is now fixed in "next".

commit 74d580bc6892f0a22bbbc573c2418b8fbf839933
Author: Sebastian Spaeth <Sebastian at SSpaeth.de>
Date:   Wed Nov 2 11:55:05 2011 +0100

    Exit "infinite" monitorloop when SyncRunner thread exits
    
    The huge UI rework patch removed some obscure logic and special handling of
    thread exit messages. It turns out that this was in fact still needed as a
    specific exit message of the SyncRunner thread signified the threatmonitor
    to quit.
    
    We will want a nicer machinery for this in the future I guess, but fix the
    eternal hang on exit by reintroducing a special exit message for the
    SyncRunner thread, and return from the infinite monitor loop if SyncRunner
    finishes.
    
    Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/offlineimap-project/attachments/20111102/d3a6efd2/attachment-0001.sig>