[PATCH 4/8] Re: Create new folders on srcrepo if needed

[Nicolas Sebrecht]

On Mon, Aug 29, 2011 at 04:00:13PM +0200, Sebastian Spaeth wrote:

> This will ignore any nametrans rules, so we might want to limit this
> only to cases where no nametrans has been specified,

I guess this behaviour would be very confusing for most end-users. I'm
not sure to understand everything myself.

Since you start ignoring nametrans rules, we do want (not might) to
limit to cases where no nametrans has been specified.

Some thoughts:

- do the remote folder creation _only if_ nametrans applied on it
  doesn't change the local folername. This use case looks to be based on
  a wrong assumption of what the created folder on remote will appear to
  the client on next run.

- do the remote folder creation, fetch the new list of folder, apply
  folderinclude on it, apply nametrans on it, apply whatever is needed
  to have the name we'll have on next run, check that the final local
  foldername matches the original local foldername:

    - if they match: accept the creation.

    - if they don't match: refuse and delete the remote foldername, or
      rename/move the original local foldername to match the resulting
      foldername.

>                                                      or we might want to
> use the nametrans setting of the dest repo.

Not sure. I agree if you're saying "we might want to use the nametrans
setting /on/ the /newly created/ dest repo".

Or, I misunderstood. :-/

-- 
Nicolas Sebrecht