[patch] Re: Fix the logic for updating maildir flags.

Sebastian Spaeth Sebastian at SSpaeth.de
Fri Jan 6 12:11:45 GMT 2012

On Fri, 2 Dec 2011 14:20:34 -0500, Rafael EspĂ­ndola wrote:
> Fix the logic for updating maildir flags.

Hi Rafael,

I just committed the below patch to the next branch, which will prevent
us from creating invalid maildir names. But this will require further
work, see the commit log why we are still not golden...

commit d5666ce91de13923f939edaf0f23ac227fb7fc06
Author: Sebastian Spaeth <Sebastian at SSpaeth.de>
Date:   Fri Jan 6 13:05:08 2012 +0100

    Don't create invalid maildir names with lower case maildir flags
    If someone had a custom :2,a flag, adding a new flag would lead to the
    invalid maildir filename ...a:2,... due to regex deficiencies not coping
    with this. Fix this so we alway produce valid maildir names.
    Note that custom flags are still problematic: as the syncing to the
    remote IMAP server will fail, the next sync will assume that they have
    been removed from the remote IMAP side and they will be removed from the
    local Maildir then. We will need to think about how to handle this. At
    least, with this patch we won't lose standard flags and won't produce
    invalid maildir names.
    Signed-off-by: Sebastian Spaeth <Sebastian at SSpaeth.de>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/offlineimap-project/attachments/20120106/3c26c218/attachment-0001.sig>

More information about the OfflineIMAP-project mailing list