Recommendations for patches (was: Re: [PATCH] Make sure folder filters are always respected.)

Eygene Ryabinkin rea at
Sun Jul 29 14:01:39 BST 2012

Sun, Jul 29, 2012 at 11:09:02AM +0000, Rog?rio Brito wrote:
> * 1 for adding the new properties etc. that you want (not changing the 
> behavior of the code).
> * 1 for actually enabling the functionality of the code that you added.

Such split is not very good: if you have bugs in the added code, then
when you'll be bisecting the revisions, it will point you to the one
that will actually enable the functionality, instead of the proper one
(that adds it).  And as other people could commit something between
these two, it will be even harder to find the real problem.
Eygene Ryabinkin                                        ,,,^..^,,,
[ Life's unfair - but root password helps!           | ]
[ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <>

More information about the OfflineIMAP-project mailing list