[PATCH] Make sure folder filters are always respected.

Sebastian Spaeth Sebastian at SSpaeth.de
Sat Sep 1 02:18:01 BST 2012

Dave Abrahams <dave at boostpro.com> writes:

> * Fix omitted check for local folder's sync_this value in
>   SyncableAccount.sync()

Hi Dave, I just pushed a patch fixing the fallout from your
change. There was a reason that we would not call getfolder() until we
had made sure that the remote folder exists and is not filtered out....
Found it by running our test suite...

commit 3476e9ab36b861fefde5211cb39a71623738dd71
Author: Sebastian Spaeth <Sebastian at SSpaeth.de>
Date:   Sat Sep 1 03:12:16 2012 +0200

    Fix fallout when filtering folders
    Previous commit e7ca5b25cba0679aa800b490d063b24c40864839 combined
    checks for filtered folders in one place. However, it turns out there
    was a reason to have them separate. getfolder() on a non-existent Maildir
    fails and there might not be an equivalent local Maildir folder for a
    filtered out IMAP folder.
    Fix this by first checking if the remote folder should be filtered, and
    only then retrieving the local folder (which should exist then).
    This bug was found by our test suite!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/offlineimap-project/attachments/20120901/4e5ac218/attachment-0001.sig>

More information about the OfflineIMAP-project mailing list