Bug in get_create_folders?

Florian Lindner mailinglists at xgm.de
Sat Sep 28 12:45:24 BST 2013


    def get_create_folders(self):
        """Is folder creation enabled on this repository?                                                                                                                                                                                                                      
        It is disabled by either setting the whole repository                                                                                                                                                                                                                  
        'readonly' or by using the 'createfolders' setting."""
        return self._readonly or self.getconfboolean('createfolders', True)

in Base.py.

should the last line not rather be?

return (not self._readonly) and self.getconfboolean('createfolders', True)

It should only return True if (readonly is False) and (createfolders is True).


If I am correct:
Should I make a pull request on github for that or you simply use it?


More information about the OfflineIMAP-project mailing list