[offlineimap] open_socket() leaks DNS requests when proxying (#189)

mitzip notifications at github.com
Sun Apr 12 16:56:11 BST 2015


socks.setdefaultproxy() has a fourth arg for sending DNS requests through the proxy
https://github.com/OfflineIMAP/offlineimap/blob/master/offlineimap/imapserver.py#L119

However, even with that fourth arg set to True, using getaddrinfo() bypasses SOCKS5 proxy for dns resolution. This also breaks .onion Tor hidden service resolution.
https://github.com/OfflineIMAP/offlineimap/blob/master/offlineimap/imaplibutil.py#L77

Might consider socks.wrapmodule().
https://github.com/Anorov/PySocks/search?utf8=%E2%9C%93&q=wrap

ping @xiaket

---
Reply to this email directly or view it on GitHub:
https://github.com/OfflineIMAP/offlineimap/issues/189
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/offlineimap-project/attachments/20150412/e1662a8b/attachment.html>


More information about the OfflineIMAP-project mailing list