<DKIM> [PATCH] make savemessagelabels honor utime_from_header

Abdó Roig-Maranges abdo.roig at gmail.com
Fri Apr 3 11:28:21 BST 2015



> I get what you mean but strictly speacking, we don't "restore the file
> mtime". We "avoid changing mtime".

Ok, I'll fix this on the next patch.



> So, utime_from_header is incompatible with quick syncs. Do we forbid
> quick sync when utime_from_header is set? Is it documented in
> offlineimap.conf?

Strictly speaking, it is not incompatible.

This patch make sure we at least do not break the assumption of
utime_from_header on a label change propagating from gmail to local. As far as I
know, quick syncs is not affected by this!

The only case in which quick sync makes use of the mtime is to detect when
someone externally (via the mail client) changes a label. This will still change
the mtime, and quick sync will still work.

But then, it doesn't make much sense to use utime_from_header with labels,
because to make label syncs from local to gmail, you will have to manually break
the assumption of utime_from_header to change the label. But the software is not
strictly broken.

If you still feel we should comment in offlineimap.conf, I'll add it on the next
round.

Abdó.





More information about the OfflineIMAP-project mailing list