<DKIM> [PATCH] make savemessagelabels honor utime_from_header

Nicolas Sebrecht nicolas.s-dev at laposte.net
Fri Apr 3 22:07:35 BST 2015

On Fri, Apr 03, 2015 at 09:31:51PM +0200, Abdó Roig-Maranges wrote:

> Are you sure about this? I think it has always meant
>   "set the mtime to whatever when first saving the message".

No, I'm not sure at all. But that would make sense! :-)

> > So that the assumption:
> >
> >  "make sure ALL local mtimes match internal date after EACH sync"
> >
> > is verified. IOW, get (3) without relying on rtime (2).
> This would make sense. My first though would be adding a new pass in BaseFolder,
> just at the end, after syncing flags, that fixes the local mtimes when
> utimes_from_header=true.
> However, I don't have much time, and since this is a feature I'm not interested
> in, nor we break it anymore than it was broken by what I said above...

Of course. I don't expect this to be implemented. It was just a side

We are late in the -rc cycle and I'd rather apply bug fixes only.

> Do you maintain a TODO list for things to do when bored?

See ./TODO.rst. Feel free to add a section for minor improvements.

> > If we do apply (3), quick sync mode is an offender to what we can expect
> > with utime_from_header.
> Well, it is a delicate thing. But we can do the the label quick sync detection
> before "fixing mtimes", and it would still work, assuming manual label changes
> update the mtime.

Plain right.

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list