reverting recent SSL-related patches
nicolas.s-dev at laposte.net
Mon Jan 12 15:09:55 GMT 2015
On Mon, Jan 12, 2015 at 01:36:39PM +0100, Nicolas Sebrecht wrote:
> > - http://codelabs.ru/patches/offlineimap/2015-Properly-re-raise-exception-to-save-original-traceback.diff
> Looks good from a quick review. Apply it.
> > - http://codelabs.ru/patches/offlineimap/2015-Fix-API-documentation-syntax.diff
> > - http://codelabs.ru/patches/offlineimap/2015-API-documentation-properly-auto-document-main-class.diff
> > - http://codelabs.ru/patches/offlineimap/2015-API-documentation-fix-typo.diff
> Not going to review these ones: it's about documentation. Apply them.
> > - http://codelabs.ru/patches/offlineimap/2015-SSL-properly-configure-certificate-and-fingerprint-validation.diff
> > It works for me both if repository has sslcacertfile and if only
> > cert_fingerprint is configured and OS-default CA bundle is present.
> Like discussed above, I'm not plainly satisfied. I have no strong
> opinion but in the same time I couldn't find a fix I'm totally satisfied
> with. Edd proposed me off-list to add yet another configuration option
> and I'm not tottaly satisfied with this fix neither.
> The added comments to the configuration file should make the
> situation clear enough. So, you might want go with the cuurent fix.
> Apply, if you think it's the best approach. Consider me out of the
> course. ,-)
I have pending work to publish into "next":
Giovanni Mascellani (1):
Drop caches after having processed folders.
Nicolas Sebrecht (4):
repository: Base: add comment about lying variable name self.uiddir
repository: IMAP.py: do not redefine string
minor: add comments
more consistent style
Wieland Hoffmann (1):
addmessageheader: Add a note about the incorrect rendering of the docstring
I'll wait for you to apply your patches so that you won't get into conflicts,
With all that work done, we should be up-to-date at merging pull requests and
patches sent to the mailing list:
I aim to release next -rc after the merges.
> > Edd, if you will be able to test this, it will be very good.
More information about the OfflineIMAP-project