<DKIM> Re:[offlineimap] Duplicates of messages copied from remote to local (#174)

[Peter Lewis]

Hi,

Thanks for following this up. It is entirely likely that I did something
wrong and ended up in the wrong place. If so, please bear with me and I
will try again.

> Peter, when you did the git bisect, which versions did you end up
> testing? I ask because this commit later got reverted.

I bisected between tag v6.5.6 (as good, since it was the last version I
knew to work fine), and tag v6.5.7 (as bad, which was where I first
noticed the problem).

I have copied the bisect log at the bottom of this email. Note that I
skipped quite a few, since there were other unrelated errors I
encountered at quite a few commits.

Strangely, I notice from the log that the revert commit for the one I
ended up at was one of the ones I ended up skipping. I don't remember
exactly what the error was though that caused me to skip it.

I will also try without autorefresh, and see if the same thing happens.

> I wonder Peter didn't use the last version. If so, I wonder the bisect
> ended up to a commit unrelated to the correct commit. Erf.

Anyway, I can do the bisecting again no problem, if I didn't do
something quite right.

> The only other thing this patch did was set the rtime correctly, which
> was later dealt with more carefully in Abdo's patches
> c094304f937e13e80ce464ff7819affd39d298cc and
> 0c17350e4f72282a7a8ac3180de713b3b322dcea. It might help to know
> whether the bug is present at that point.

Should I maybe test these two next?

Thanks again,

Peter.


git bisect start
# good: [7770b5ff73737d1269eb1ba7554b8d3486c7f5ec] Add friendly message about Python 3.x being unsupported
git bisect good 7770b5ff73737d1269eb1ba7554b8d3486c7f5ec
# bad: [ca1ce256ecb1d56f00c7342b121b6079b536ef0f] v6.5.7
git bisect bad ca1ce256ecb1d56f00c7342b121b6079b536ef0f
# good: [5318af606e4ebd0906cf3c9cc5745a6dd2b150e3] docs: expand documentation of the gmail labels syncing
git bisect good 5318af606e4ebd0906cf3c9cc5745a6dd2b150e3
# good: [5318af606e4ebd0906cf3c9cc5745a6dd2b150e3] docs: expand documentation of the gmail labels syncing
git bisect good 5318af606e4ebd0906cf3c9cc5745a6dd2b150e3
# skip: [97689ee484fd4fd39824c58957ef430b420f94c3] v6.5.7-rc3
git bisect skip 97689ee484fd4fd39824c58957ef430b420f94c3
# skip: [4015c1d84cffe26b005f5480a998b6d6f48b6832] release.sh: dont publish anything by script
git bisect skip 4015c1d84cffe26b005f5480a998b6d6f48b6832
# skip: [4015c1d84cffe26b005f5480a998b6d6f48b6832] release.sh: dont publish anything by script
git bisect skip 4015c1d84cffe26b005f5480a998b6d6f48b6832
# skip: [aec5430457819ee538f22577852c3cf93288b1a3] website-doc.sh: include user contributions
git bisect skip aec5430457819ee538f22577852c3cf93288b1a3
# skip: [60cc58c38e7bbce8c03a785ebafbf5e8d1571a82] DNS of the website changed, reflect it
git bisect skip 60cc58c38e7bbce8c03a785ebafbf5e8d1571a82
# skip: [478091f9ac68c2f44d7d1a6392141eba2ba9fdbc] fix paths in systemd README
git bisect skip 478091f9ac68c2f44d7d1a6392141eba2ba9fdbc
# skip: [115d141218c3deb7d2fc92ea87732b4420c4a5d2] Update offlineimap.conf
git bisect skip 115d141218c3deb7d2fc92ea87732b4420c4a5d2
# skip: [8df8ea098373c7c8019ed306f3c9dace405310ed] Merge branch 'bb/systemd-touchups' into next
git bisect skip 8df8ea098373c7c8019ed306f3c9dace405310ed
# skip: [9e63fa3784b8adc7b1dd28871ec5e80404d32b12] fix: folder/*: never set self.messagelist to None
git bisect skip 9e63fa3784b8adc7b1dd28871ec5e80404d32b12
# skip: [b7789268b7c904a50c804b53b2c57996c797c7ba] test: handle imap.gmx.net server: workarounds
git bisect skip b7789268b7c904a50c804b53b2c57996c797c7ba
# skip: [cd962d40a8febaacdb7ea5eaceaa79d840ef417c] MANUAL: add known issues entry about socktimeout for suspended sessions
git bisect skip cd962d40a8febaacdb7ea5eaceaa79d840ef417c
# skip: [4f19927cee34ecc5b1556a0d8423856633cff266] systemd: remove explicit `-c` argument
git bisect skip 4f19927cee34ecc5b1556a0d8423856633cff266
# skip: [d36209a305306a46152b3e28323d31baa48edc6f] add proxy support powered by PySocks
git bisect skip d36209a305306a46152b3e28323d31baa48edc6f
# skip: [ecc2af9f99523cdba137ac059056de8f9ed16c5e] test: handle literal string
git bisect skip ecc2af9f99523cdba137ac059056de8f9ed16c5e
# skip: [a817400d768a13e168a028e28475dd0c013cb5a8] report exceptions via exit code
git bisect skip a817400d768a13e168a028e28475dd0c013cb5a8
# skip: [731129396c3a610a147a7b7e798e5a41de9153f0] fix: don't copy messages if not necessary
git bisect skip 731129396c3a610a147a7b7e798e5a41de9153f0
# skip: [5ecd557dfbd8d734abe35b24dd30a813ab2bbadf] doc: add IMAP RFCs
git bisect skip 5ecd557dfbd8d734abe35b24dd30a813ab2bbadf
# skip: [fe92025c8ff14d6bf8afbbaed05fa1895fb5875e] release.sh: git_shortlog() -> get_git_history()
git bisect skip fe92025c8ff14d6bf8afbbaed05fa1895fb5875e
# skip: [71693b7d8c6cd51219e811eee7bb03af341ae544] Maildir: fix imports of emailutil
git bisect skip 71693b7d8c6cd51219e811eee7bb03af341ae544
# skip: [0dfe57d0ca425356e01c0fbec8c18da6ebf925be] offlineimap.conf: explain the remotehost line must match the domain defined in the certificate
git bisect skip 0dfe57d0ca425356e01c0fbec8c18da6ebf925be
# good: [846ebeb2aa90f288364f9ab7bc23a21e2f07f89b] docs: GitAdvanced: write the "sending pull request" section
git bisect good 846ebeb2aa90f288364f9ab7bc23a21e2f07f89b
# skip: [2d14f005d7f74c70269a8626b749782bcaaab037] contrib: add systemd configuration files
git bisect skip 2d14f005d7f74c70269a8626b749782bcaaab037
# skip: [6be2656350f551fc6e60ffb975fa090780c04702] doc: move non-API documentation to the website
git bisect skip 6be2656350f551fc6e60ffb975fa090780c04702
# skip: [4217fccb821f35238bc63c3e672093911a6ddc1d] mbnames: add option to write the file once per account
git bisect skip 4217fccb821f35238bc63c3e672093911a6ddc1d
# skip: [10aa7c19e6ae7c4e42c884e0368a4bb363b21d26] CONTRIBUTING: fix links
git bisect skip 10aa7c19e6ae7c4e42c884e0368a4bb363b21d26
# skip: [4a5f32febd6c005812c2560a601b1a3d5471ee6e] maildir deletion must not fail
git bisect skip 4a5f32febd6c005812c2560a601b1a3d5471ee6e
# skip: [4a5f32febd6c005812c2560a601b1a3d5471ee6e] maildir deletion must not fail
git bisect skip 4a5f32febd6c005812c2560a601b1a3d5471ee6e
# skip: [dd2a70fc68bc52f783a0df5c1f8c5399d80ae707] website-doc.sh: learn to export Changelog's definitions
git bisect skip dd2a70fc68bc52f783a0df5c1f8c5399d80ae707
# skip: [8be040d3a01a44de3754dc0106c9337ae2725674] fix typo
git bisect skip 8be040d3a01a44de3754dc0106c9337ae2725674
# skip: [cf2a2c769cee47b42681fd9f6516cf79d843eade] offlineimap(1): fix formatting
git bisect skip cf2a2c769cee47b42681fd9f6516cf79d843eade
# good: [a629b4e0e72156413b88807022497e27ea6d1c3f] do not error if `remoteuser` is not configured
git bisect good a629b4e0e72156413b88807022497e27ea6d1c3f
# skip: [8fc806113301c93f4dad7ddc1a21fca246e9933c] offlineimap.conf: document the "utime_from_header" option
git bisect skip 8fc806113301c93f4dad7ddc1a21fca246e9933c
# skip: [c8e5f32ebaa1d8c840bc8a589e337ebef090c6f6] Merge branch 'kappa-error-in-exit-status' into next
git bisect skip c8e5f32ebaa1d8c840bc8a589e337ebef090c6f6
# skip: [5a4e4fd0c2b2c369040bb5b3f51aaf9c5a87d9c1] rename utime_from_message to utime_from_header
git bisect skip 5a4e4fd0c2b2c369040bb5b3f51aaf9c5a87d9c1
# skip: [f46f08ecf8d9bb729d690e27dae682c60cb2ed12] README: deep cleanup
git bisect skip f46f08ecf8d9bb729d690e27dae682c60cb2ed12
# skip: [05fa3118787e2e14d7f10560cdd16f48ca8ad06a] Revert "fix: don't loose local mails because of maxage"
git bisect skip 05fa3118787e2e14d7f10560cdd16f48ca8ad06a
# skip: [223a7d0f7f700cb8642d5722be351e993e9ef665] Merge branch 'mjhoy-fix-dst' into next
git bisect skip 223a7d0f7f700cb8642d5722be351e993e9ef665
# skip: [9b55cc547545490407fad83c70778ff284aa1621] website-doc.sh: fix function call
git bisect skip 9b55cc547545490407fad83c70778ff284aa1621
# skip: [c9ce43313f124bc5e49e0fed59fa857cc8017016] fix the Makefile(s)
git bisect skip c9ce43313f124bc5e49e0fed59fa857cc8017016
# skip: [f1525094469db1a26ece022964465f90a1db1080] Makefile: learn to build websitedoc
git bisect skip f1525094469db1a26ece022964465f90a1db1080
# skip: [2c3ef50a3dc6da2c66968c28d64f46e25b3506bd] contrib/release.sh: fix debug statement
git bisect skip 2c3ef50a3dc6da2c66968c28d64f46e25b3506bd
# skip: [509d1404b04eedd6c2c10116dedaf2ea993d65a2] release.sh: website: fix feeding the latest stable and rc
git bisect skip 509d1404b04eedd6c2c10116dedaf2ea993d65a2
# skip: [3a00ddaa846e66de6cc7480fd0145f7cefd1a1a9] docs: minor improvements
git bisect skip 3a00ddaa846e66de6cc7480fd0145f7cefd1a1a9
# bad: [afcd64003567857523a4d48bdc2a36c6d952e902] test: folder separator could be dot or slash
git bisect bad afcd64003567857523a4d48bdc2a36c6d952e902
# bad: [09fca0ccb1395851f9ff66fbe57ab6b401cbc5ca] remove obsolete documentation
git bisect bad 09fca0ccb1395851f9ff66fbe57ab6b401cbc5ca
# bad: [8229800e0ce52508d6b86be7bde52438f831ffd3] Changelogs: move format back to markdown/kramdown to be more compatible with Jekyll
git bisect bad 8229800e0ce52508d6b86be7bde52438f831ffd3
# bad: [7c7e7f92b1997abd8bce552a00ce0a7d9b3c2dc4] website: learn to build the sphinx documentation
git bisect bad 7c7e7f92b1997abd8bce552a00ce0a7d9b3c2dc4
# bad: [bbc84ead0f9d6f86bbe29307d95d15bd66e0d6bf] move some documentation to the website
git bisect bad bbc84ead0f9d6f86bbe29307d95d15bd66e0d6bf
# bad: [171a7a07972fec0ca0485ff9e598f094fee14a49] allow fetching the website in our git work tree
git bisect bad 171a7a07972fec0ca0485ff9e598f094fee14a49
# bad: [25513e90387f60831b94c6041de08db5ba12e95f] fix: don't loose local mails because of maxage
git bisect bad 25513e90387f60831b94c6041de08db5ba12e95f
# first bad commit: [25513e90387f60831b94c6041de08db5ba12e95f] fix: don't loose local mails because of maxage