PARTIALLY REMOVING MAXAGE (was: [PATCH v4] make maxage use UIDs to avoid timezone issues)

Nicolas Sebrecht nicolas.s-dev at laposte.net
Tue Mar 31 15:50:52 BST 2015


On Tue, Mar 31, 2015 at 04:59:15AM -0400, Janna Martl wrote:

> More notes about this:
> 
> * I took out the bit in folder/IMAP.py _msgs_to_fetch(), where we expand
> the list to min(uids within maxage). The reason was that it would only
> be used on an initial sync (where the Maildir was empty), and the extra
> messages would get filled in on the next sync. I don't have a strong
> opinion about this.

Ok.

> * The startdate option doesn't have anything to do with what we were
> talking about; it was something that I'd kind of wanted, and seemed easy
> once I'd done the rest of this.

Right, would have make sense to make a dedicated commit, though. Don't
care about that, it's done and we can go with the mix.

> * I think I should test this more, but am sending it so you can comment.

Very good. That's what I understood from the missing sign-off-by line.

> Sorry for holding up the show with this,

We are both holding it up, BTW. :-)

And it's fine. I'd rather have a patch as good as possible and postpone
the next release than insert crappy code we'll have to fix later.

Good job.

-- 
Nicolas Sebrecht




More information about the OfflineIMAP-project mailing list