[BUG] offlineimap stopped picking up passwords from netrc

[Nicolas Sebrecht]

On Mon, Jun 27, 2016 at 06:10:05PM +0200, Łukasz Żarnowiecki wrote:

> 08e17de7e289384514f67903e2f609c8c83d50a5
> 
> This commit introduces regression which causes Python 3 to be not able
> to authenticate with password taken from netrc while Python 2 version
> remains good.

Yes. As said in

https://github.com/OfflineIMAP/offlineimap/pull/341#discussion_r67436489

the netrc feature is the last remaining quering method of password not
supporting Unicode correctly. I did not implement this myself because of
my lazyness.

> You were to fast this time with introducing this change :)  We need to
> more carefully test our changes on both versions.

I don't think I've been too quick about that since I knew the above
limitation. The patch is improving the current state of the expected
types while it's still not complete.

>                                                    I will try not to be
> a bottleneck when it comes to testing for your patchsets in the near
> future.

The more we will be near the stable, the more we will merge bug fixes
only and the more I will go slow. Early releases cadidates might be
partially broken. That's not a big deal. Also, there is no regression.
The current code is improving support for non-ASCII passwords and it's
limited to py3.

I wanted to have the -rc3 now to avoid a too much big release candidate.
We can make as many as cadidates as we want.

I'd say you're welcome to make your first update to official repository.
There are pending patches. ,-)

-- 
Nicolas Sebrecht