[PATCH 07/15] Encode utf-8 argument for md5 function

Nicolas Sebrecht nicolas.s-dev at laposte.net
Fri May 13 12:16:11 BST 2016


On Fri, May 13, 2016 at 08:44:02AM +0200, Łukasz Żarnowiecki wrote:

> Yes, it will definetely breaks the current setups.  I can think of three
> possible solutions:
> 
> * Somehow detect that we are comming from offlineimap 6.7 and rewrite the
>   names.

We could stop the sync of a folder having any filename with a unexpected
MD5 in order to prevent from doing bad things.

> * Introduce CLI option as you suggested to make a migration.  This is
> 	definetely worse approach than previous one, users should be careful enough
> 	to read release news and let's be hones, they won't.

The CLI option has the benefit we can backport the feature. Some users
will want to downgrade offlineimap for whatever reason. They will have
the same issue in the other way around.

> * Forget about the names and let's break the setups.

I guess we will have complaints. Also, I'm not sure what we do when MD5
does not match. I worry about email deletions on remote if the filenames
are fully ignored by the merge algo.

-- 
Nicolas Sebrecht




More information about the OfflineIMAP-project mailing list