[PATCH 11/15] Do not encode elements of list
dolohow at outlook.com
Tue May 17 19:19:36 BST 2016
On Tue, May 10, 2016 at 02:42:07AM +0200, Nicolas Sebrecht wrote:
> On Tue, May 10, 2016 at 01:18:33AM +0200, Łukasz Żarnowiecki wrote:
> > Signed-off-by: Łukasz Żarnowiecki <dolohow at outlook.com>
> > ---
> > offlineimap/imaplib2.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/offlineimap/imaplib2.py b/offlineimap/imaplib2.py
> > index 2ff06c1..a242e6c 100755
> > --- a/offlineimap/imaplib2.py
> > +++ b/offlineimap/imaplib2.py
> > @@ -2337,7 +2337,7 @@ class _IdleCont(object):
> > MonthNames = [None, 'Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun',
> > 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']
> > -Mon2num = dict(list(zip((x.encode() for x in MonthNames[1:]), list(range(1, 13)))))
> > +Mon2num = dict(list(zip((x for x in MonthNames[1:]), list(range(1, 13)))))
> > InternalDate = re.compile(r'.*INTERNALDATE "'
> > r'(?P<day>[ 0123][0-9])-(?P<mon>[A-Z][a-z][a-z])-(?P<year>[0-9][0-9][0-9][0-9])'
> Won't take this one as already explained.
I tried Python3 version of imaplib2, but it does not work even with
Python3. I can try reach developers and work with them while this patch
makes offlineimap work both with Python2 and Python3 without any visible
regression on my setup and the change is so easy that maintenance would
not be pain in the ass.
By the way why we bundle offlineimap with imaplib2 in the first place?
Does offlineimap makes some modification to their code?
More information about the OfflineIMAP-project