[PATCH 01/15] Raise exceptions as defined in PEP 3109

Nicolas Sebrecht nicolas.s-dev at laposte.net
Wed May 18 00:45:00 BST 2016


On Tue, May 17, 2016 at 07:56:52PM +0200, Łukasz Żarnowiecki wrote:

> From 3939bfb172ceb0c212a2d055abf64bdbc218dee7 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=C5=81ukasz=20=C5=BBarnowiecki?= <dolohow at outlook.com>
> Date: Tue, 17 May 2016 19:49:52 +0200
> Subject: [PATCH] Raise exceptions using six module
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit

Garbage.

> There is no other way to make Python2 and Python3 happy, because syntax
> raise E, V, T is incompatible with the latter.

> Signed-off-by: Łukasz Żarnowiecki <dolohow at outlook.com>
> ---
>  offlineimap/CustomConfig.py             |  6 ++++--
>  offlineimap/accounts.py                 | 10 ++++++----
>  offlineimap/folder/Gmail.py             |  7 ++++---
>  offlineimap/folder/GmailMaildir.py      |  7 ++++---
>  offlineimap/folder/IMAP.py              | 15 ++++++++-------
>  offlineimap/folder/LocalStatus.py       |  6 ++++--
>  offlineimap/folder/LocalStatusSQLite.py | 11 +++++++----
>  offlineimap/folder/Maildir.py           | 16 +++++++++-------
>  offlineimap/folder/UIDMaps.py           | 10 ++++++----
>  offlineimap/imaplibutil.py              |  4 +++-
>  offlineimap/imapserver.py               | 12 +++++++-----
>  offlineimap/repository/IMAP.py          |  7 ++++---
>  offlineimap/repository/__init__.py      |  8 ++++----
>  13 files changed, 70 insertions(+), 49 deletions(-)

We must add this new dependency in the README, at least. Documentation
about the installation will require updates.

Also, I think a blog post about this change would be great, too. It's
the first time we are introducing a dependency not packaged with Python
core.

I'm confident that six is widely used enough to be available in most
distributions, though.

Applied, thanks.

-- 
Nicolas Sebrecht




More information about the OfflineIMAP-project mailing list