<DKIM> [PATCH] Pass relevant maildir filenames to newmail_hook

Nicolas Sebrecht nicolas.s-dev at laposte.net
Sat Jul 20 08:29:07 BST 2019

On Sat, Jul 20, 2019 at 11:10:53AM +1000, Cameron Simpson wrote:
> On 19Jul2019 01:18, Nicolas Sebrecht <nicolas.s-dev at laposte.net> wrote:
> > On Thu, Jul 18, 2019 at 01:34:46PM +0300, gwn wrote:
> > > So that the hook can implement advanced features that acts on the
> > > newly synced mail content.
> [...]
> > >              if self.newmail_hook != None:
> > 
> > BTW, this check should be merged with the 'have_newmail' check.
> Is there a reason this is not "is not" instead of "!=" ?
> If you're being Pythonic, a plain "if self.newmail_hook:" would suffice, but
> an equality check with None is very meaningful. It is a singleton, so you
> should be using "is" or falling back to the unadorned truthy/falsey bare "if
> self.newmail_hook:".

"is not None" is the most restrictive check to what is expected. That's
what we tend to use. It's the most meaningful about what we are

I don't follow all the pythonist policies but I don't block/reject
patches from contributors because of this.

Nicolas Sebrecht

More information about the OfflineIMAP-project mailing list