[Openstack-devel] Bug#728939: openstack-debian-images: Using the -ar option truncates 5% off the end of the resized filesystem.

[Steven Menexas]

Package: openstack-debian-images
Version: 0.3~bpo70+1
Severity: normal

Dear Maintainer,
*** Please consider answering these questions, where appropriate ***

   * What led up to the situation?
Bug is trigered when booting the disk images created by running
"build-openstack-debian-images -r wheezy -ar ...".
   * What exactly did you do (or not do) that was effective (or
     ineffective)?
Not using the -ar option avoids this bug, but results in larger disk images.
   * What was the outcome of this action?
Booting the buggy disk images in kvm fails with fsck reporting root
partition size less than filesystem size.
   * What outcome did you expect instead?
The resized partition should be about 5% larger to include the full
size of the fs calculated in variable FINAL_IMG_SIZE.
The variable is in units of 2**20 bytes, but parted is called from the
script using a suffix of 'M' for mkpart begin/end.
Parted interprets 'M' to mean units of 10**6 bytes.

This patch seems to help, however I am not sure if the Mi suffix to
parted is universaly available:

--- bad/usr/sbin/build-openstack-debian-image	2013-07-28
10:47:49.000000000 -0400
+++ good/usr/sbin/build-openstack-debian-image	2013-11-06
20:55:51.000000000 -0500
@@ -165,7 +165,7 @@
 #dd if=/dev/null bs=1M seek=1024 of=${AMI_NAME}

 ${PARTED} -s ${AMI_NAME} mktable msdos
-${PARTED} -s -a optimal ${AMI_NAME} mkpart primary ext3 1M 100%
+${PARTED} -s -a optimal ${AMI_NAME} mkpart primary ext3 1Mi 100%
 ${PARTED} -s ${AMI_NAME} set 1 boot on
 install-mbr ${AMI_NAME}
 RESULT_KPARTX=`kpartx -av ${AMI_NAME} 2>&1`
@@ -387,7 +387,7 @@
 if [ "${AUTOMATIC_RESIZE}" = "yes" ] ; then
 	# Rebuild a smaller partition table
 	parted -s ${AMI_NAME} rm 1
-	parted -s ${AMI_NAME} mkpart primary ext3 1M ${FINAL_IMG_SIZE}M
+	parted -s ${AMI_NAME} mkpart primary ext3 1Mi ${FINAL_IMG_SIZE}Mi
 	parted -s ${AMI_NAME} set 1 boot on

 	# Add 2M for the 1M at the beginning of the partition and some
additionnal space


-- System Information:
Debian Release: 7.2
  APT prefers stable-updates
  APT policy: (991, 'stable-updates'), (991, 'stable'), (206,
'oldstable'), (205, 'oldstable-updates'), (204, 'oldstable'), (110,
'stable'), (101, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.10-0.bpo.3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages openstack-debian-images depends on:
ii  debootstrap      1.0.48+deb7u1
ii  dpkg             1.16.12
ii  extlinux         2:4.05+dfsg-6+deb7u1
ii  initramfs-tools  0.113~bpo70+1
ii  kpartx           0.4.9+git0.4dfdaf2b-7~deb7u2
ii  mbr              1.1.11-5+b1
ii  parted           2.3-12
ii  qemu-utils       1.1.2+dfsg-6a

openstack-debian-images recommends no packages.

openstack-debian-images suggests no packages.

-- no debconf information