[Openstack-devel] Bug#728943: openstack-debian-images: Using this script modifies /etc/modules in the real root-fs.

[Steven Menexas]

Package: openstack-debian-images
Version: 0.3~bpo70+1
Severity: minor

Dear Maintainer,
*** Please consider answering these questions, where appropriate ***

   * What led up to the situation?
I ran the script several times to create disk images.
I later noticed /etc/modules in my real root-fs had a repeating block
of 4 lines (1 of which contains somewhat variable data.) appended to
it.
Since I recently ran this script I checked it and found that it
appended these 4 lines to /etc/modules each time it is run.
   * What exactly did you do (or not do) that was effective (or
     ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?
I am not sure of the exact effect of appending these 4 lines, but I
strongly suspect that they are intended for the disk image filesystem.
If these lines cause problems on next reboot of real root-fs's, bug
severity might need to be upgraded.
Each time the script is run to create a disk image it appends:
"# Required for cinder hotplug
acpiphp
pci_hotplug
 ${MOUNT_DIR}
"
to /etc/modules, MOUNT_DIR is set to `mktemp -d -t
build-debimg.XXXXXX` by the script.
This patch should fix, assuming appending these lines is appropiate
for the mounted disk image:

--- bad/usr/sbin/build-openstack-debian-image	2013-07-28
10:47:49.000000000 -0400
+++ good2/usr/sbin/build-openstack-debian-image	2013-11-06
21:38:09.000000000 -0500
@@ -245,7 +245,7 @@
 echo "# Required for cinder hotplug
 acpiphp
 pci_hotplug
-" ${MOUNT_DIR}>>/etc/modules
+" >> ${MOUNT_DIR}/etc/modules

 # Enable bash-completion by default
 if [ ${EXTRA} = "yes" ] ; then

-- System Information:
Debian Release: 7.2
  APT prefers stable-updates
  APT policy: (991, 'stable-updates'), (991, 'stable'), (206,
'oldstable'), (205, 'oldstable-updates'), (204, 'oldstable'), (110,
'stable'), (101, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.10-0.bpo.3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages openstack-debian-images depends on:
ii  debootstrap      1.0.48+deb7u1
ii  dpkg             1.16.12
ii  extlinux         2:4.05+dfsg-6+deb7u1
ii  initramfs-tools  0.113~bpo70+1
ii  kpartx           0.4.9+git0.4dfdaf2b-7~deb7u2
ii  mbr              1.1.11-5+b1
ii  parted           2.3-12
ii  qemu-utils       1.1.2+dfsg-6a

openstack-debian-images recommends no packages.

openstack-debian-images suggests no packages.

-- no debconf information