[Openstack-devel] Bug#728943: Bug#728943: openstack-debian-images: Using this script modifies /etc/modules in the real root-fs.

[Thomas Goirand]

On 11/07/2013 11:56 AM, Steven Menexas wrote:
> Package: openstack-debian-images
> Version: 0.3~bpo70+1
> Severity: minor
> 
> Dear Maintainer,
> *** Please consider answering these questions, where appropriate ***
> 
>    * What led up to the situation?
> I ran the script several times to create disk images.
> I later noticed /etc/modules in my real root-fs had a repeating block
> of 4 lines (1 of which contains somewhat variable data.) appended to
> it.
> Since I recently ran this script I checked it and found that it
> appended these 4 lines to /etc/modules each time it is run.
>    * What exactly did you do (or not do) that was effective (or
>      ineffective)?
>    * What was the outcome of this action?
>    * What outcome did you expect instead?
> I am not sure of the exact effect of appending these 4 lines, but I
> strongly suspect that they are intended for the disk image filesystem.
> If these lines cause problems on next reboot of real root-fs's, bug
> severity might need to be upgraded.
> Each time the script is run to create a disk image it appends:
> "# Required for cinder hotplug
> acpiphp
> pci_hotplug
>  ${MOUNT_DIR}
> "
> to /etc/modules, MOUNT_DIR is set to `mktemp -d -t
> build-debimg.XXXXXX` by the script.
> This patch should fix, assuming appending these lines is appropiate
> for the mounted disk image:
> 
> --- bad/usr/sbin/build-openstack-debian-image	2013-07-28
> 10:47:49.000000000 -0400
> +++ good2/usr/sbin/build-openstack-debian-image	2013-11-06
> 21:38:09.000000000 -0500
> @@ -245,7 +245,7 @@
>  echo "# Required for cinder hotplug
>  acpiphp
>  pci_hotplug
> -" ${MOUNT_DIR}>>/etc/modules
> +" >> ${MOUNT_DIR}/etc/modules
> 
>  # Enable bash-completion by default
>  if [ ${EXTRA} = "yes" ] ; then

Hi,

Thanks for this bug report, I've corrected the problem in the Git, and
will upload the fix son to Sid. It wont reach backports until the
package reaches Testing (because that's the rule).

Cheers,

Thomas