[PKG-Openstack-devel] Bug#755651: Bug#755651: First set of patches

[Thomas Goirand]

On 08/05/2014 06:00 AM, Raphael Hertzog wrote:
> Control: tag -1 + confirmed
> 
> Hello Thomas,
> 
> I spent some time on horizon this evening and I came up with this
> set of patches. It fixes all regressions that I saw except one:
> 
> FAIL: test_update_project_when_default_role_does_not_exist (openstack_dashboard.dashboards.admin.projects.tests.UpdateProjectWorkflowTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/rhertzog/tmp/django17/horizon/openstack_dashboard/test/helpers.py", line 83, in instance_stub_out
>     return fn(self, *args, **kwargs)
>   File "/home/rhertzog/tmp/django17/horizon/openstack_dashboard/dashboards/admin/projects/tests.py", line 1458, in test_update_project_when_default_role_does_not_exist
>     self.client.get(url)
> AssertionError: NotFound not raised
> 
> I haven't understood this one and it's already late so I don't want to spend
> more time on it.
> 
> You'll see that the patches will need some discussion with upstream because
> at least in one case I'm not sure that my fix is correct, it might be that the
> test data need to be fixed...
> 
> Cheers,

Awesome! Thanks Raphael.

I started upstreaming the patches. Here's the review IDs:
https://review.openstack.org/111930
https://review.openstack.org/111932
https://review.openstack.org/111934
https://review.openstack.org/111936

Let's hope it is well received.

Cheers,

Thomas Goirand (zigo)