[PKG-Openstack-devel] Bug#773694: Please properly remove conffiles

Gaudenz Steinlin gaudenz at debian.org
Mon Dec 22 17:21:32 UTC 2014


> Hi,
>
> What happened, is that all logrotate scripts for individual daemons have
> been merged into a single logrotate file. This has been made possible
> because OpenStack daemons aren't restarted because of logrotate anymore,
> instead, we use the "copytruncate" mode, which does work much better.
>
> So no, the logrotate file from <service>-common shouldn't be removed,
> it's the opposite way that should be done, and this is some maintenance
> that should happen on the DSA server, not on the packages (because on
> the package side, the logrotate duplicate files have already been removed).
>
> I am unsure why it was still there on the DSA machine. Maybe because it
> was modified by the DSA? Or because you didn't do --purge when
> upgrading? Anyway, it's normal CONFFILES as much as I know.

No there is a bug in your package. Nobody should have to use --purge to
remove unmodified conffiles on upgrade that are no longer part of the
package. Instead of just dropping these files from the package you
should use dpkg-maintscript-helper like this in the preinst, postinst
and postrm maintainer scripts:

dpkg-maintscript-helper rm_conffile \
               conffile prior-version package -- "$@"

See the dpkg-maintscript-helper manpage section on "Removing a conffile"
for further details. There is also more documentation about how to
properly move conffiles from one package to another in the Debian wiki.

Also a note in NEWS.Debian about the changes location would be nice.
This way people that did modify the logrotate configuration are warned
that they have to adapt the new configuraiton file from their old
*.dpkg-bak files.

I'm not reopening these bug reports as I don't want to play bug
ping-pong, but I firmly believe that there is a bug in your package that
should be fixed.

Gaudenz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/openstack-devel/attachments/20141222/03797115/attachment-0009.sig>


More information about the Openstack-devel mailing list