[PKG-Openstack-devel] Bug#755656: Patch still not enough

Thomas Goirand zigo at debian.org
Sun Sep 7 07:53:55 UTC 2014


Hi,

After applying the given 2 patches, there's still unit tests errors:

======================================================================
FAIL: test_basic_form (tests.BootstrapTemplateTagTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/home/zigo/sources/openstack/icehouse/python-django-bootstrap-form/build-area/python-django-bootstrap-form-3.1.0/tests/__init__.py",
line 64, in test_basic_form
    self.assertHTMLEqual(html, content)
  File "/usr/lib/python2.7/dist-packages/django/test/testcases.py", line
645, in assertHTMLEqual
    self.fail(self._formatMessage(msg, standardMsg))
AssertionError: <div class="form-group">
<label class="  control-label" for="id_char_field">
Cha [truncated]... != <div class="form-group">
<label class="  control-label" for="id_char_field">
Cha [truncated]...
  <div class="form-group">
  <label class="  control-label" for="id_char_field">
  Char field
  </label><div class=" ">
  <input class=" form-control" id="id_char_field" name="char_field"
type="text" />
  </div>
  </div><div class="form-group">
  <label class="  control-label" for="id_choice_field">
  Choice field
  </label><div class=" ">
  <select class=" form-control" id="id_choice_field" name="choice_field">
  <option value="0">
  Zero
  </option><option value="1">
  One
  </option><option value="2">
  Two
  </option>
  </select>
  </div>
  </div><div class="form-group">
  <label class="  control-label">
  Radio choice
  </label><div class>
  <div class="radio">
  <label>
- <input id="id_radio_choice_0" name="radio_choice" type="radio"
value="0" />Zero
?       -----------------------

+ <input name="radio_choice" type="radio" value="0" />Zero
  </label>
  </div><div class="radio">
  <label>
- <input id="id_radio_choice_1" name="radio_choice" type="radio"
value="1" />One
?       -----------------------

+ <input name="radio_choice" type="radio" value="1" />One
  </label>
  </div><div class="radio">
  <label>
- <input id="id_radio_choice_2" name="radio_choice" type="radio"
value="2" />Two
?       -----------------------

+ <input name="radio_choice" type="radio" value="2" />Two
  </label>
  </div>
  </div>
  </div><div class="form-group">
  <label class="  control-label" for="id_multiple_choice">
  Multiple choice
  </label><div class=" ">
  <select class=" form-control" id="id_multiple_choice"
multiple="multiple" name="multiple_choice">
  <option value="0">
  Zero
  </option><option value="1">
  One
  </option><option value="2">
  Two
  </option>
  </select>
  </div>
  </div><div class="form-group">
  <label class="  control-label" for="id_multiple_checkbox">
  Multiple checkbox
  </label><div class=" multiple-checkbox">
  <ul id="id_multiple_checkbox">
  <li>
  <label for="id_multiple_checkbox_0">
  <input id="id_multiple_checkbox_0" name="multiple_checkbox"
type="checkbox" value="0" />Zero
  </label>
  </li><li>
  <label for="id_multiple_checkbox_1">
  <input id="id_multiple_checkbox_1" name="multiple_checkbox"
type="checkbox" value="1" />One
  </label>
  </li><li>
  <label for="id_multiple_checkbox_2">
  <input id="id_multiple_checkbox_2" name="multiple_checkbox"
type="checkbox" value="2" />Two
  </label>
  </li>
  </ul>
  </div>
  </div><div class="form-group">
  <label class="  control-label" for="id_file_fied">
  File fied
  </label><div class=" ">
  <input id="id_file_fied" name="file_fied" type="file" />
  </div>
  </div><div class="form-group">
  <label class="  control-label" for="id_password_field">
  Password field
  </label><div class=" ">
  <input class=" form-control" id="id_password_field"
name="password_field" type="password" />
  </div>
  </div><div class="form-group">
  <label class="  control-label" for="id_textarea">
  Textarea
  </label><div class=" ">
  <textarea class=" form-control" cols="40" id="id_textarea"
name="textarea" rows="10" />
  </div>
  </div><div class="form-group">
  <div class>
  <div class="checkbox">
  <label>
  <input id="id_boolean_field" name="boolean_field" type="checkbox" /><span>
  Boolean field
  </span>
  </label>
  </div>
  </div>
  </div>

======================================================================
FAIL: test_horizontal_form (tests.BootstrapTemplateTagTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/home/zigo/sources/openstack/icehouse/python-django-bootstrap-form/build-area/python-django-bootstrap-form-3.1.0/tests/__init__.py",
line 77, in test_horizontal_form
    self.assertHTMLEqual(html, content)
  File "/usr/lib/python2.7/dist-packages/django/test/testcases.py", line
645, in assertHTMLEqual
    self.fail(self._formatMessage(msg, standardMsg))
AssertionError: <div class="form-group">
<label class=" col-lg-2 col-sm-2 control-label" for="id [truncated]...
!= <div class="form-group">
<label class=" col-lg-2 col-sm-2 control-label" for="id [truncated]...
  <div class="form-group">
  <label class=" col-lg-2 col-sm-2 control-label" for="id_char_field">
  Char field
  </label><div class="  col-lg-10 col-sm-10">
  <input class=" form-control" id="id_char_field" name="char_field"
type="text" />
  </div>
  </div><div class="form-group">
  <label class=" col-lg-2 col-sm-2 control-label" for="id_choice_field">
  Choice field
  </label><div class="  col-lg-10 col-sm-10">
  <select class=" form-control" id="id_choice_field" name="choice_field">
  <option value="0">
  Zero
  </option><option value="1">
  One
  </option><option value="2">
  Two
  </option>
  </select>
  </div>
  </div><div class="form-group">
  <label class=" col-lg-2 col-sm-2 control-label">
  Radio choice
  </label><div class=" col-lg-10 col-sm-10">
  <div class="radio">
  <label>
- <input id="id_radio_choice_0" name="radio_choice" type="radio"
value="0" />Zero
?       -----------------------

+ <input name="radio_choice" type="radio" value="0" />Zero
  </label>
  </div><div class="radio">
  <label>
- <input id="id_radio_choice_1" name="radio_choice" type="radio"
value="1" />One
?       -----------------------

+ <input name="radio_choice" type="radio" value="1" />One
  </label>
  </div><div class="radio">
  <label>
- <input id="id_radio_choice_2" name="radio_choice" type="radio"
value="2" />Two
?       -----------------------

+ <input name="radio_choice" type="radio" value="2" />Two
  </label>
  </div>
  </div>
  </div><div class="form-group">
  <label class=" col-lg-2 col-sm-2 control-label" for="id_multiple_choice">
  Multiple choice
  </label><div class="  col-lg-10 col-sm-10">
  <select class=" form-control" id="id_multiple_choice"
multiple="multiple" name="multiple_choice">
  <option value="0">
  Zero
  </option><option value="1">
  One
  </option><option value="2">
  Two
  </option>
  </select>
  </div>
  </div><div class="form-group">
  <label class=" col-lg-2 col-sm-2 control-label"
for="id_multiple_checkbox">
  Multiple checkbox
  </label><div class=" col-lg-10 col-sm-10 multiple-checkbox">
  <ul id="id_multiple_checkbox">
  <li>
  <label for="id_multiple_checkbox_0">
  <input id="id_multiple_checkbox_0" name="multiple_checkbox"
type="checkbox" value="0" />Zero
  </label>
  </li><li>
  <label for="id_multiple_checkbox_1">
  <input id="id_multiple_checkbox_1" name="multiple_checkbox"
type="checkbox" value="1" />One
  </label>
  </li><li>
  <label for="id_multiple_checkbox_2">
  <input id="id_multiple_checkbox_2" name="multiple_checkbox"
type="checkbox" value="2" />Two
  </label>
  </li>
  </ul>
  </div>
  </div><div class="form-group">
  <label class=" col-lg-2 col-sm-2 control-label" for="id_file_fied">
  File fied
  </label><div class="  col-lg-10 col-sm-10">
  <input id="id_file_fied" name="file_fied" type="file" />
  </div>
  </div><div class="form-group">
  <label class=" col-lg-2 col-sm-2 control-label" for="id_password_field">
  Password field
  </label><div class="  col-lg-10 col-sm-10">
  <input class=" form-control" id="id_password_field"
name="password_field" type="password" />
  </div>
  </div><div class="form-group">
  <label class=" col-lg-2 col-sm-2 control-label" for="id_textarea">
  Textarea
  </label><div class="  col-lg-10 col-sm-10">
  <textarea class=" form-control" cols="40" id="id_textarea"
name="textarea" rows="10" />
  </div>
  </div><div class="form-group">
  <div class=" col-lg-10 col-lg-offset-2 col-sm-10 col-sm-offset-2">
  <div class="checkbox">
  <label>
  <input id="id_boolean_field" name="boolean_field" type="checkbox" /><span>
  Boolean field
  </span>
  </label>
  </div>
  </div>
  </div>

----------------------------------------------------------------------
Ran 2 tests in 0.307s

FAILED (failures=2)



More information about the Openstack-devel mailing list