[PKG-Openstack-devel] Bug#870600: rabbitmq-server OCF resource agent does not support rabbitctl exit status 69 for nodedown

[Bas Couwenberg]

Source: rabbitmq-server
Version: 3.6.6-1
Severity: important

Dear Maintainer,

The rabbitmq-server OCF resource agent stopped working correctly in stretch,
it is unable to determine that the node is down due to rabbitctl changing the
exit status.

In jessie the `/usr/sbin/rabbitmqctl -n rabbit at localhost status` command
returned exit status 2, in stretch it changes to exit status 69.

This causes the OCF resource agent to fail with:

 ERROR: Unexpected return from rabbitmqctl -n rabbit at localhost status: 69

The attached patch updates the resource agent to handle exit status 60 the same
as exit status 2, fixing the issue.

Please consider applying the patch and resolve this issue with a
proposed-update for stretch.

Kind Regards,

Bas

-- System Information:
Debian Release: 9.1
  APT prefers stable-debug
  APT policy: (500, 'stable-debug'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff --git a/debian/changelog b/debian/changelog
index ce6823c..e8acc29 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+rabbitmq-server (3.6.6-1+deb9u1) stretch; urgency=medium
+
+  * Non-maintainer upload.
+  * Add patch to fix rabbitmq-server OCF resource agent.
+    `rabbitmqctl status` now uses exit status 69 when the node is down,
+    instead of 2 as before, both exit status 2 and 69 are now handled by
+    the OCF resource agent for the same case.
+
+ -- Bas Couwenberg <sebastic at debian.org>  Thu, 03 Aug 2017 10:05:11 +0200
+
 rabbitmq-server (3.6.6-1) unstable; urgency=medium
 
   [ Ond?ej Nov? ]
diff --git a/debian/patches/ocf.patch b/debian/patches/ocf.patch
new file mode 100644
index 0000000..f9b960e
--- /dev/null
+++ b/debian/patches/ocf.patch
@@ -0,0 +1,14 @@
+Description: Also handle rabbitctl exit status 69 for nodedown.
+Author: Bas Couwenberg <sebastic at debian.org>
+
+--- a/scripts/rabbitmq-server.ocf
++++ b/scripts/rabbitmq-server.ocf
+@@ -256,7 +256,7 @@ rabbitmqctl_action() {
+             ocf_log debug "RabbitMQ server is running normally"
+             return $OCF_SUCCESS
+             ;;
+-        2)
++        2|69)
+             ocf_log debug "RabbitMQ server is not running"
+             return $OCF_NOT_RUNNING
+             ;;
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..16260eb
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+ocf.patch