[PKG-Openstack-devel] Bug#884815: jenkins-job-builder: debian/rules clean does not run dh_clean

[Andreas Beckmann]

Source: jenkins-job-builder
Version: 2.0.0~b2-1
Severity: serious
Justification: Policy 4.9

Hi,

from the attached pbuilder --twice buildlog after the first build has
finished:

 dpkg-source --before-build jenkins-job-builder-2.0.0~b2
dpkg-buildpackage: info: host architecture amd64
dpkg-source: info: using options from jenkins-job-builder-2.0.0~b2/debian/source/options: --extend-diff-ignore=^[^/]*[.]egg-info/
 fakeroot debian/rules clean
pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
py3versions: no X-Python3-Version in control file, using supported versions
dh clean --with python2,python3,sphinxdoc
   dh_auto_clean
pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
        python setup.py clean -a
running clean
removing 'build/lib.linux-x86_64-2.7' (and everything under it)
'build/bdist.linux-x86_64' does not exist -- can't clean it
'build/scripts-2.7' does not exist -- can't clean it
        find . -name \*.pyc -exec rm {} \+
   debian/rules override_dh_clean
make[1]: Entering directory '/build/jenkins-job-builder-2.0.0~b2'
pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
py3versions: no X-Python3-Version in control file, using supported versions
rm -rf doc/build build .testrepository
make[1]: Leaving directory '/build/jenkins-job-builder-2.0.0~b2'
 dpkg-source -b jenkins-job-builder-2.0.0~b2
dpkg-source: info: using options from jenkins-job-builder-2.0.0~b2/debian/source/options: --extend-diff-ignore=^[^/]*[.]egg-info/
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: error: unwanted binary file: debian/python3-jenkins-job-builder/usr/share/doc/python3-jenkins-job-builder/changelog.Debian.gz
dpkg-source: error: unwanted binary file: debian/python-jenkins-job-builder/usr/share/doc/python-jenkins-job-builder/changelog.Debian.gz
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/changelog.Debian.gz
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/objects.inv
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/ajax-loader.gif
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/comment-bright.png
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/comment-close.png
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/comment.png
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/down-pressed.png
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/down.png
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/file.png
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/minus.png
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/plus.png
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/up-pressed.png
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder-doc/usr/share/doc/jenkins-job-builder-doc/html/_static/up.png
dpkg-source: error: unwanted binary file: debian/jenkins-job-builder/usr/share/doc/jenkins-job-builder/changelog.Debian.gz
dpkg-source: error: detected 16 unwanted binary files (add them in debian/source/include-binaries to allow their inclusion).
dpkg-buildpackage: error: dpkg-source -b jenkins-job-builder-2.0.0~b2 subprocess returned exit status 29


Without calling dh_clean, all the temporary stuff in debian/ is retained,
but luckily dpkg-source chokes on unwanted binaries, refusing to create
a source package full of binary cruft.

The override_dh_clean target needs to call dh_clean as the last command
after any further cleanup it does.


Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jenkins-job-builder_2.0.0~b2-1_twice.log.gz
Type: application/gzip
Size: 28783 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/openstack-devel/attachments/20171219/998b4e4c/attachment-0001.bin>