[PKG-Openstack-devel] Bug#865648: Does not include security sources for all releases

[Steve McIntyre]

Package: openstack-debian-images
Version: 1.19
Severity: serious
Tags: patch

The code is currently *only* adding security sources into
apt/sources.list when building for wheezy or jessie. This is clearly
wrong. I've just had to rebuild our stretch images again (9.0.1 to
9.0.2) to get expected updates in.

Trivial fix is to *always* include security:

diff --git a/build-openstack-debian-image b/build-openstack-debian-image
index 3a8d7d6..e0e670a 100755
--- a/build-openstack-debian-image
+++ b/build-openstack-debian-image
@@ -484,13 +484,11 @@ echo "debian.example.com" >${MOUNT_DIR}/etc/hostname
 echo "deb ${SOURCE_LIST_MIRROR} ${RELEASE} main
 deb-src ${SOURCE_LIST_MIRROR} ${RELEASE} main" >${MOUNT_DIR}/etc/apt/sources.list
 
-if [ "${RELEASE}" = "wheezy" ] || [ "${RELEASE}" = "jessie" ] ; then
-       echo "deb ${SOURCE_LIST_MIRROR} ${RELEASE}-updates main
+echo "deb ${SOURCE_LIST_MIRROR} ${RELEASE}-updates main
 deb-src ${SOURCE_LIST_MIRROR} ${RELEASE}-updates main
 deb http://security.debian.org/ ${RELEASE}/updates main
 deb-src http://security.debian.org/ ${RELEASE}/updates main
 " >>${MOUNT_DIR}/etc/apt/sources.list
-fi
 
 if [ "${RELEASE}" = "wheezy" ] ; then
        echo "deb ${SOURCE_LIST_MIRROR} wheezy-backports main


-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages openstack-debian-images depends on:
ii  debootstrap      1.0.89
ii  dosfstools       4.1-1
ii  extlinux         3:6.03+dfsg-14.1
ii  initramfs-tools  0.130
ii  kpartx           0.6.4-5
ii  mbr              1.1.11-5.1
ii  parted           3.2-17
ii  qemu-utils       1:2.8+dfsg-6

openstack-debian-images recommends no packages.

openstack-debian-images suggests no packages.

-- no debconf information