[PKG-Openstack-devel] Accepted python-eventlet 0.20.0-1 (source all) into unstable

[Ondrej Novy]

Hi,

2017-11-13 10:55 GMT+01:00 Thomas Goirand <zigo at debian.org>:

> Ondrej, if you feel bad about it, I'm sorry. I don't want to let you go,
> and I'm ok to "revert" the upload. Unfortunately, IMO, "revert" here
> can't mean using another version than 0.20.0. That's the version used by
> upstream Pike, and we should keep this version. If you don't agree,
> please let me know why.
>

I agree. We should respect upper-constrains. 0.20.0 is correct. Revert
means move "back" to DPMT, to pybuild.

Since 0.20.0 is already uploaded to the archive, if we're to use
> pristine-tar, then what should happen is importing the currently
> uploaded orig.tar.gz in the Git. I don't think that's really a problem.
>

yep, but not only this needs to be done. See below.


> If you're ok with such a plan, Ondrej, then please do it. The thing is,
> there's currently an RC bug opened because Eventlet is slowly moving to
> Python 3, and the currently uploaded version can't even compile. I've
> pushed patches to fix the issue in the OpenStack git. I'm ok to upload
> it, though I would very much prefer to have peer review of these
> patches. Especially the one modifying the regexp. I haven't used much
> regex in Python, though my understanding is that the r'' form of strings
> prevent the interpretation of the escape sequences. Though rb'' is
> needed for Python 3, it crashes the Python compiler in Python 2. If
> setting only b'', it compile on both, but then unit tests are failing in
> Python 3, because the regex becomes bad. My patch therefore removes the
> r, and add more slashes to avoid interpretation by Python. That's the
> part which I would like peer review on. Lamby wrote that he's not sure
> about this patch...
>

I can help fix Eventlet for Py2.7, but I'm not fine to do revert of that
migration myself. You messed it, you should clean it up. I'm not going to
cleanup your mess.

You should:

   - sync DPMT git with current state in Debian archive - with correct tags
   - revert some of changes you made (back to pybuild, maintainers, ...),
   keep 0.20.0
   - remove OS git

Then I can continue.


> I actually see in that list of packages some that have OpenStack as
> upstream, as per what I wrote on IRC:
>

OS upstream:


> - migrate

- python-cliff
> - python-cloudfiles
> - python-django-openstack-auth
>
- python-pyghmi

- python-yaql


this are definitely in wrong group, please move them to openstack/libs.
They are all OS upstreams.

there are not OS upstream:

> - python-dogpile.cache

- python-tenacity
>
- python-rtslib-fb

- python-wrapt


Tenacity is already moved to DPMT.


> >   * do you disagree with having python-eventlet in DPMT?
>
> I don't think it's a good idea, as it's used so much in OpenStack. I'm
> ok with everything else, if we consider the above list of packages though.
>

Openstack uses many many many Python libs which are in DPMT. That's nothing
new.


> The message on IRC was an attempt to discuss the mater with you, with
> the thoughts that things could be reverted anyway, so it wouldn't mater
> much. The thing is, I'm really closed to have everything finished, and I
> want to get this done ASAP.
>

don't hurry. Communication is more important than doing things ASAP. You
already did this mistake again and again.

Yeah. I just want to do things too fast, sorry for that. Please don't
> make it such a drama, uploads can be reverted.
>

my feelings about it can't be reverted. And reverting this kind of upload
is not simple. But it's your work to revert it, so you are wasting your
time (and my for writing this emails)


> As I'm mostly the only one working on this, yes it does hurt. I thought
> that Eventlet was blocking, and wanted to try fast.
>

you can try anything without uploading. You can even fix it inside DPMT.
That migration to OS team was completely useless for this kind of fix.

>
> That's exactly my thinking too, and it was my thinking that, when doing
> it, if anyone wasn't happy of what I was doing, things could be reverted
> anyway.
>

if you promise you will communicate better I can try to forget this. With
better a mean:

   - talk first, before breaking any deals already made in team
   - respect other opinions, talk about reasons
   - before doing big changes, talk about reasons (in advance, before
   uploads)

Now, I've been a bit frustrated that everyone promised to do some work,
> and that I've done mostly all again. Ondrej, I would have loved to see
> more of your uploads. Are you swamped with work, just like Daniel is?
>

I'm swamped, as everybody is. But I'm trying to help, as you seen.

-- 
Best regards
 Ondřej Nový

Email: novy at ondrej.org
PGP: 3D98 3C52 EB85 980C 46A5  6090 3573 1255 9D1E 064B
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/openstack-devel/attachments/20171113/8d632c76/attachment-0001.html>