[PKG-Openstack-devel] Bug#881702: python-subunit2sql: Missing BD on testresources

[James Page]

Package: python-subunit2sql
Version: 1.8.0-3
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * d/control: Add missing BD on python{3}-testresources.

Package won't pass its unit tests without this dependency installed:

--- import errors ---
Failed to import test module: subunit2sql.tests.migrations.test_model_sync
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/unittest2/loader.py", line 456, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python2.7/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
    __import__(name)
  File "subunit2sql/tests/migrations/test_model_sync.py", line 17, in <module>
    from oslo_db.sqlalchemy import test_migrations
  File "/usr/lib/python2.7/dist-packages/oslo_db/sqlalchemy/test_migrations.py", line 34, in <module>
    from oslo_db.sqlalchemy import provision
  File "/usr/lib/python2.7/dist-packages/oslo_db/sqlalchemy/provision.py", line 32, in <module>
    import testresources
ImportError: No module named testresources

oslo.db does not hard depend on testresources, its only required as part
of the 'fixtures' dependency set:

 fixtures =
    testresources>=2.0.0 # Apache-2.0/BSD
    testscenarios>=0.4 # Apache-2.0/BSD

so dependences looking to use the test migration codepath need to install
this directly.

Thanks for considering the patch.


-- System Information:
Debian Release: stretch/sid
  APT prefers artful-updates
  APT policy: (500, 'artful-updates'), (500, 'artful-security'), (500, 'artful')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.13.0-16-generic (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff -Nru python-subunit2sql-1.8.0/debian/control python-subunit2sql-1.8.0/debian/control
--- python-subunit2sql-1.8.0/debian/control	2017-10-26 04:31:05.000000000 +0100
+++ python-subunit2sql-1.8.0/debian/control	2017-11-14 09:50:30.000000000 +0000
@@ -33,6 +33,7 @@
  python-six,
  python-sqlalchemy,
  python-stevedore,
+ python-testresources,
  python-testscenarios,
  python-testtools,
  python3-alembic,
@@ -49,6 +50,7 @@
  python3-six,
  python3-sqlalchemy,
  python3-stevedore,
+ python3-testresources,
  python3-testscenarios,
  python3-testtools,
  subunit,