[PKG-Openstack-devel] Bug#906552: watcher: FTBFS in buster/sid (failing tests)

[Santiago Vila]

Package: src:watcher
Version: 1.8.0-5
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions
py3versions: no X-Python3-Version in control file, using supported versions
dh build-indep --buildsystem=python_distutils --with python3,systemd,sphinxdoc
   dh_update_autotools_config -i -O--buildsystem=python_distutils
   dh_autoreconf -i -O--buildsystem=python_distutils
   dh_auto_configure -i -O--buildsystem=python_distutils
dh_auto_configure: Please use the third-party "pybuild" build system instead of python-distutils
dh_auto_configure: This feature will be removed in compat 12.
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
pyversions: missing X(S)-Python-Version in control file, fall back to debian/pyversions
pyversions: missing debian/pyversions file, fall back to supported versions

[... snipped ...]

----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/watcher/tests/decision_engine/strategy/strategies/test_zone_migration.py", line 96, in setUp
    model = self.fake_c_cluster.generate_scenario_1()
  File "/<<PKGBUILDDIR>>/watcher/tests/decision_engine/model/faker_cluster_state.py", line 119, in generate_scenario_1
    return self.load_model('scenario_1.xml')
  File "/<<PKGBUILDDIR>>/watcher/tests/decision_engine/model/faker_cluster_state.py", line 50, in load_model
    return modelroot.ModelRoot.from_xml(self.load_data(filename))
  File "/<<PKGBUILDDIR>>/watcher/decision_engine/model/model_root.py", line 224, in from_xml
    model.add_node(node)
  File "/usr/lib/python3/dist-packages/oslo_concurrency/lockutils.py", line 274, in inner
    return f(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/watcher/decision_engine/model/model_root.py", line 60, in add_node
    super(ModelRoot, self).add_node(node.uuid, node)
TypeError: add_node() takes 2 positional arguments but 3 were given


======================================================================
FAIL: watcher.tests.decision_engine.test_scheduling.TestDecisionEngineSchedulingService.test_start_de_scheduling_service
watcher.tests.decision_engine.test_scheduling.TestDecisionEngineSchedulingService.test_start_de_scheduling_service
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "/<<PKGBUILDDIR>>/watcher/tests/decision_engine/test_scheduling.py", line 54, in test_start_de_scheduling_service
    self.assertTrue(bool(fake_collector.cluster_data_model))
  File "/<<PKGBUILDDIR>>/watcher/decision_engine/model/collector/base.py", line 137, in cluster_data_model
    self._cluster_data_model = self.execute()
  File "/<<PKGBUILDDIR>>/watcher/tests/decision_engine/model/faker_cluster_state.py", line 56, in execute
    return self._cluster_data_model or self.build_scenario_1()
  File "/<<PKGBUILDDIR>>/watcher/tests/decision_engine/model/faker_cluster_state.py", line 82, in build_scenario_1
    model.add_node(node)
  File "/usr/lib/python3/dist-packages/oslo_concurrency/lockutils.py", line 274, in inner
    return f(*args, **kwargs)
  File "/<<PKGBUILDDIR>>/watcher/decision_engine/model/model_root.py", line 60, in add_node
    super(ModelRoot, self).add_node(node.uuid, node)
TypeError: add_node() takes 2 positional arguments but 3 were given


----------------------------------------------------------------------
Ran 1697 tests in 118.448s

FAILED (failures=262)
make[1]: *** [debian/rules:31: override_dh_install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:6: binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made with "dpkg-buildpackage -A" in my autobuilder.
Most probably, it also fails here in reproducible builds:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/watcher.html

where you can get a full build log if you need it.

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.