[PKG-Openstack-devel] Bug#907077: neutron-fwaas-dashboard: missing build-dependency on python3-django-horizon

[Steve Langasek]

Package: neutron-fwaas-dashboard
Version: 1.3.0-1
Severity: minor
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu cosmic ubuntu-patch

In Ubuntu, neutron-fwaas-dashboard fails to build because it relies on
python3-django-horizon at build time, but does not have a direct
build-dependency on it:

for i in 3.7 3.6 ; do \
        PYTHONPATH=/<<PKGBUILDDIR>>/debian/tmp/usr/lib/python3/dist-packages \
                NOSE_WITH_OPENSTACK=1 \
                NOSE_OPENSTACK_COLOR=1 \
                NOSE_OPENSTACK_RED=0.05 \
                NOSE_OPENSTACK_YELLOW=0.025 \
                NOSE_OPENSTACK_SHOW_ELAPSED=1 \
                python$i /<<PKGBUILDDIR>>/manage.py test neutron_fwaas_dashboard.test -v 2 --settings=neutron_fwaas_dashboard.test.settings ; \
done
Traceback (most recent call last):
  File "/<<PKGBUILDDIR>>/manage.py", line 23, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/lib/python3/dist-packages/django/core/management/__init__.py", line
 364, in execute_from_command_line
    utility.execute()
  File "/usr/lib/python3/dist-packages/django/core/management/__init__.py", line
 308, in execute
    settings.INSTALLED_APPS
  File "/usr/lib/python3/dist-packages/django/conf/__init__.py", line 56, in __getattr__
 364, in execute_from_command_line
    utility.execute()
  File "/usr/lib/python3/dist-packages/django/core/management/__init__.py", line 308, in execute
    settings.INSTALLED_APPS
  File "/usr/lib/python3/dist-packages/django/conf/__init__.py", line 56, in __getattr__
    self._setup(name)
  File "/usr/lib/python3/dist-packages/django/conf/__init__.py", line 41, in _setup
    self._wrapped = Settings(settings_module)
  File "/usr/lib/python3/dist-packages/django/conf/__init__.py", line 110, in __init__
    mod = importlib.import_module(self.SETTINGS_MODULE)
  File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/<<PKGBUILDDIR>>/neutron_fwaas_dashboard/test/settings.py", line 14, in <module>
    from horizon.test.settings import *  # noqa
ModuleNotFoundError: No module named 'horizon'
make[1]: *** [debian/rules:23: override_dh_install] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:6: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

[...]

  (https://launchpad.net/ubuntu/+source/neutron-fwaas-dashboard/1.3.0-1)

In Debian, this missing build dependency is not causing a build failure
because it's pulled in indirectly via openstack-dashboard.  In Ubuntu,
openstack-dashboard currently depends on python-django-horizon |
python3-django-horizon, so the alternative is resolved to
python-django-horizon instead of the needed python3 version.

Since neutron-fwaas-dashboard references horizon directly in its tests, it
should build-depend on it directly, not rely on it being pulled in via some
other build dependency.

Please consider the attached patch.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru neutron-fwaas-dashboard-1.3.0/debian/control neutron-fwaas-dashboard-1.3.0/debian/control
--- neutron-fwaas-dashboard-1.3.0/debian/control	2018-02-21 05:09:04.000000000 -0800
+++ neutron-fwaas-dashboard-1.3.0/debian/control	2018-08-23 11:00:57.000000000 -0700
@@ -15,6 +15,7 @@
 Build-Depends-Indep:
  openstack-dashboard (>= 3:13.0.0~rc1),
  python3-coverage,
+ python3-django-horizon,
  python3-django-nose,
  python3-mock,
  python3-mox3,