[PKG-Openstack-devel] Bug#887188: Bug#887188: nova-compute should depend on e2fsprogs explicitly

[Thomas Goirand]

On 01/23/2018 09:28 AM, Andreas Henriksson wrote:
> On Sun, Jan 14, 2018 at 08:08:22PM +0100, Helmut Grohne wrote:
>> Package: nova-compute
> [...]
>> /etc/nova/rootwrap.d/compute.filters contains e2fsck, mkfs.ext3, mkfs.ext4, resize2fs and tune2fs. According to file it is a ASCII text
> [...]
> 
> My understanding after spending about 2 seconds looking at the initial
> part of https://wiki.openstack.org/wiki/Rootwrap is that nova-compute
> likely doesn't execute these commands itself. I would thus assume
> neither of Depends, Recommends or Suggests is suitable in this case and
> the bug report should simply be closed.
> 
> Would be great to hear maintainers view on this.
> 
> Regards,
> Andreas Henriksson

Andreas,

rootwrap is just a wrapper around sudo to improve security. So in this
case, nova-compute really *is* using the above tools, and should depend
on e2fsprogs. I'll push a change with nova-common depending on it.

Cheers,

Thomas Goirand (zigo)