[PKG-Openstack-devel] Bug#909048: Bug#909048: This isn't a bug

[Thomas Goirand]

Hi Santiago!

On 9/14/19 7:00 PM, Santiago Vila wrote:
> I guess the things you do in override_dh_install before that are
> required for the tests to work, otherwise I suppose you would have
> just moved the tests to dh_auto_test.

Indeed~

With many packages in OpenStack, if you want the tests to run correctly,
the Python package *must* be installed in the Python folder, together
with the correctly generated egg-info and all. Otherwise, tests may just
fail. This is so increasingly the case, that I've now taken the habit to
always do it for all OpenStack services as much as possible, otherwise I
get some surprises and waste my time.

What's not completely apparent is that pkgos-dh_auto_test does:
PYTHONPATH=$(CURDIR)/debian/tmp/usr/lib/python3/dist-packages

when running the tests.

The same way, pkgos-dh_auto_install has now gained a --in-tmp parameter
so that pkgos-dh_auto_test can automatically set the correct PYTHONPATH
value that will help the tests to pass.

Also, this package (ie: Glare) is a bad example, because it is largely
unmaintained upstream, which is why I kind of lost interest in it, and
didn't care enough for fixing issues for it for Buster. I probably
should ask for it to be removed from Debian... :(

Cheers,

Thomas Goirand (zigo)