[parted-devel] Re: Parted 1.8.0rc1 changes.

[David Cantrell]

Debarshi 'Rishi' Ray wrote:
> Here is a 'trivial' patch for parted/parted.c, for displaying the
> device model and maufacturer information during the 'print' command. I
> saw the TODO comment in the code, and thought someone might have
> forgot to add the code.
> 
> *** parted.c    2006-09-21 02:24:28.000000000 +0000
> --- parted.rishi.c      2006-09-21 02:26:43.000000000 +0000
> ***************
> *** 1252,1257 ****
> --- 1252,1258 ----
>                                            - 1 );
>          printf ("\n");
>          /* TODO: insert dev->model and transport here */
> +       printf(_("Model: %s\n"), (*dev)->model);
>          printf (_("Disk %s: %s\n"), (*dev)->path, end);
>          printf (_("Sector size (logical/physical): %lldB/%lldB\n"),
>                          (*dev)->sector_size, (*dev)->phys_sector_size);
> 
> 
> Hope you find it useful.

Thanks for the patch.  Please send *unified* diffs in the future. 
Despite being named contextual diffs, they actually contain less context 
and are far less useful than unified diffs.

'diff -urNp' is my preferred command for diffing trees.

> By the way, what is being referred to as 'transport'?

The interface, bus, driver, etc.

-- 
David Cantrell
Red Hat / Westford, MA