[parted-devel] [PATCH] New test for cloning of disk labels

[Otavio Salvador]

"Debarshi 'Rishi' Ray" <debarshi.ray at gmail.com> writes:

> Please find attached a patch to add a new test for the cloning of disk labels.
>
> I have a feeling that this is leading to too much of duplication of
> code. What do you say?

Well, I have the same feeling but I'm not sure if we should include a
high complexity here to reduce the amount of code.

Tests are mechanical things and we should try to keep them as simple
as possible to avoid code mistakes and also to be easy to manipulate
each one to try to find where exactly is the bug we're trying to kill.

Let's now do the code review as usual ;-)

> +                /* Not implemented yet. */
> +                if (strncmp (type->name, "aix", 3) == 0
> +                    || strncmp (type->name, "dvh", 3) == 0)
> +                        continue;

Why dvh is being skiped? I thought that aix was the only missing one.

>  int main(void)
>  {
>          int number_failed;
>          Suite *suite = suite_create("Disk Label");
>          TCase *tcase_basic = tcase_create("Create");
> +        TCase *tcase_clone = tcase_create ("Clone");
                                           ^^^ the style on this file
                                           is different
  
> +        tcase_add_checked_fixture (tcase_clone, create_disk, destroy_disk);
> +        tcase_add_test (tcase_clone, test_clone_label);
> +        tcase_set_timeout (tcase_clone, 0); /* disable timeout for this test */
> +        suite_add_tcase (suite, tcase_clone);
                          ^^^ same here

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."