[parted-devel] [PATCH] New test for cloning of disk labels

[Otavio Salvador]

"Debarshi 'Rishi' Ray" <debarshi.ray at gmail.com> writes:

>> Why dvh is being skiped? I thought that aix was the only missing one.
>
> Trying to clone dvh generates a backtrace, which does not result in
> the failing of the test. Should I include it, and regard this
> behaviour as a bug in libparted?

Yes. It looks as a bug on ped_disk_destroy. By some unknown reason the
disk has been left on update_mode. We need to check and fix it :-)

>> >          TCase *tcase_basic = tcase_create("Create");
>> > +        TCase *tcase_clone = tcase_create ("Clone");
>>                                            ^^^ the style on this file
>>                                            is different
>
> The test code does not follow Parted's convention with respect to
> brackets. I have followed the convention followed in the rest of the
> code. The older test code may need to be fixed.

Agree. We need to make it follow but it should be done in a separate
patch.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://otavio.ossystems.com.br
---------------------------------------------
"Microsoft sells you Windows ... Linux gives
 you the whole house."